search

walles / moar

Moar is a pager. It's designed to just do the right thing without any configuration.
Other
587 stars 17 forks source link

Add missing arches to cross-compilation #120

Closed ctrlcctrlv closed 1 year ago

ctrlcctrlv commented 1 year ago

No way to build on Ubuntu if you don't even have arm64/amd64 Linux builds :-)

walles commented 1 year ago

Which of these architecture combos do you personally need right now?

walles commented 1 year ago

Does 053e54 resolve your problem?

No way to build on Ubuntu if you don't even have arm64/amd64 Linux builds :-)

ctrlcctrlv commented 1 year ago

No? Why are you against building the arches people need?

ctrlcctrlv commented 1 year ago

If you, the upstream, do not distribute a 64-bit binary for Linux at all, but weirdly do distribute i386, it's pretty difficult to convince maintainers of package repositories that the project is serious enough to be included. And since this is a Go project for a PPA the easiest thing for me to do would be to just wrap your binary? I don't get why you closed this.

walles commented 1 year ago

I seem to have mis-interpreted your intention with this PR, sorry about that.

Based on your initial PR comment I assumed that the problem you wanted solved was this:

That is now solved by 053e354623a6573d68328e09e17d046a0179c51c.

But that seems to have been a mis-interpretation on my part.

Which problem is it that you want solved?

The reasoning behind i386 is that that single binary will work on both x64 and i386. Not sure how well it holds up though, do you have any counter example?

AFAIR, I started out with an x64 Linux binary, but then I ended up in some 32 bit Docker image and was unable to run moar there. So I decided on one binary for both platforms.

But as you're hinting at, maybe I should have an x64 binary for Linux for marketing reasons, whether that's strictly needed or not.

Regards /Johan

walles commented 1 year ago

First of all, I apologize for my slow response time here :(.

But regarding this:

for a PPA the easiest thing for me to do would be to just wrap your binary

Binary PPAs seem not to be allowed: "Note: We do not allow uploading pre-built binary packages."

Not sure I found the right one though, but reading on, what that guide wants is for you to "Create your source package, upload it and Launchpad will build binaries and then host them in your own apt repository."

Are these the instructions you're following, or did you find some others that do allow for packaging binaries?

walles commented 1 year ago

Tagging with Debian packaging since if this had been Debian packaged you'd already have had it in Ubuntu: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=944035

walles commented 1 year ago

It seems like #137 is the goal here, closing in favor of that one.