search

walles / moar

Moar is a pager. It's designed to just do the right thing without any configuration.
Other
674 stars 19 forks source link

latest moar breaks in iterm2 #188

Closed rwmitchell closed 10 months ago

rwmitchell commented 10 months ago

I updated to the latest rev and moar completely borked the terminal. After running ./moar MOUSE.md I get:

image

and I get an execute: prompt that doesn't let me do anything.

I then walked thru the various commits. The last working commit for me is: 711960c606c922b284c110ef84f47decb0a59ef8.

commit 0ddefbdeb79cd03d47852daaa0974080326b9e40 fails with:

image

I'm using iTerm2 Build 3.5.0beta18.

postsolar commented 10 months ago

I'm getting the first, but not the second error on respective commits on foot terminal.

When given one filename, moar panics as on the first screenshot. When given multiple filenames, it prints a normal error. When given either one or multiple filenames and piped into another program as described in https://github.com/walles/moar/commit/f4af673d3c22e8435f51ee384ae7c67168bf4d38 it works without errors.

rwmitchell commented 10 months ago

The latest update fixes moar from crashing, but it has lost colorization of the same file.

This is from my older version (v1.22.3-3-g305d247):

image

And this from the current version (v1.23.0-3-g35b0ffc):

image

both are generated from the shell, only switching between moar and ./moar Has something else changed that requires and update of settings?

Thanks for all your work.!

rwmitchell commented 10 months ago

version v1.23.2 seems to fix my issues.

walles commented 10 months ago

version v1.23.2 seems to fix my issues.

Thanks for confirming @rwmitchell!