walles / moar

Moar is a pager. It's designed to just do the right thing without any configuration.
Other
600 stars 17 forks source link

Unhandled search key event <...> #20

Closed rameshdharan closed 4 years ago

rameshdharan commented 4 years ago

Trying out moar on my macOS Catalina workstation. I reproed this both with HEAD and the 0.9.17 official release:

  1. export PAGER=moar
  2. man bash
  3. hit '/', then ctrl-c, ctrl-r, other keypresses that don't do anything

After quitting I see in my terminal, e.g.

$ man bash
Please post the following report at <https://github.com/walles/moar/issues>,
or e-mail it to johan.walles@gmail.com.

Version: 0.9.17
LANG   : en_US.UTF-8
TERM   : xterm-256color

GOOS    : darwin
GOARCH  : amd64
Compiler: gc
NumCPU  : 4

2019/12/06 00:25:56 Unhandled key event 18
2019/12/06 00:25:57 Unhandled rune keypress 'l'
2019/12/06 00:25:57 Unhandled rune keypress 's'
2019/12/06 00:25:57 Unhandled rune keypress 's'
2019/12/06 00:25:58 Unhandled key event 3
2019/12/06 00:25:58 Unhandled key event 18
rameshdharan commented 4 years ago

As a workaround of course I can do:

export PAGER='moar 2>/dev/null'

But I'd prefer having this be the default and maybe only printing that stuff with --verbose or similar?

walles commented 4 years ago

A --debug flag sounds like a plan, I'll look at implementing something using https://github.com/sirupsen/logrus.

walles commented 4 years ago

Fix released in 0.9.18, please try it out @rameshdharan and let me know if it helped!