search

walles / moar

Moar is a pager. It's designed to just do the right thing without any configuration.
Other
585 stars 17 forks source link

new moar hung for few second while searching #209

Closed ciscohack closed 1 month ago

ciscohack commented 1 month ago

In the latest moar, it seems the old search and freeze issue is back. while searching for any keyword CLI freeze for a few seconds.

moar version v1.23.13

walles commented 1 month ago

How big is your input?

I just tried with a 14MB file and searching was OK but not great.

ciscohack commented 1 month ago

it has 5 lakh lines but this search freeze was fixed in old build when last time i reported if you remember..freeze is more evident when you accidently type wrong word not exist in file

walles commented 1 month ago

it has 5 lakh lines

I looked it up, this means five hundred thousand lines right?

ciscohack commented 1 month ago

it has 5 lakh lines

I looked it up, this means five hundred thousand lines right?

yes correct!

walles commented 1 month ago

I'm not sure if this fixes it, but 1.23.14 should at least be less bad in this regard.

Please try it out and see what you think.

ciscohack commented 1 month ago

@walles Thanks

walles commented 1 month ago

7b032b2fa4bffe0b7a396040c9d05010e699a8a6 should make the search a lot faster for large files.

That version uses all available cores for searching, rather than just one.