walles / moar

Moar is a pager. It's designed to just do the right thing without any configuration.
Other
587 stars 17 forks source link

--dumb is not recognised option #85

Closed michal-piekarski closed 2 years ago

michal-piekarski commented 2 years ago

Calling moar --dumb causes: flag provided but not defined: -dumb

walles commented 2 years ago

Dumb question maybe (pun intended), but what do you expect when passing --dumb?

michal-piekarski commented 2 years ago

I assumed that I should submit this in line with readme:

The intention is that Moar should work as a drop-in replacement for Less. If you find that Moar doesn't work that way, please report it!

I think this means that if I replace less --dumb with moar --dumb it should have the same effect. This is not the case, moar --dumb returns an error about undefined option.

Description of the --dumb option for less is:

       -d or --dumb
              The -d option suppresses the error message normally
              displayed if the terminal is dumb; that is, lacks some
              important capability, such as the ability to clear the
              screen or scroll backward.  The -d option does not
              otherwise change the behavior of less on a dumb terminal.

I don't expect 100% the same functionality but at least the option should be recognized - even if it does nothing.

walles commented 2 years ago

Thanks for the clarification @michal-piekarski!

My intent was never to support every option in less, but rather have a nice pager that is obvious to use if you're coming from less.

I changed the phrasing you're referring to to try to convey this better. In retrospect I think the previous phrasing could totally be interpreted the way you did.

For now I'm weakly against adding flags just to ignore them. If lots of people show up asking for this I might reconsider.