walles / riff

A diff filter highlighting which line parts have changed
MIT License
253 stars 5 forks source link

Add macports moar +pager variant support #55

Closed halostatue closed 11 months ago

halostatue commented 11 months ago

MacPorts now has a variant of the moar port which installs moar as moar-pager. We are currently applying this patch during builds but would prefer to avoid patching upstream builds if possible. This will also prevent any other packaging system from needing to maintain a similar patch should the take the approach that we have or something similar.

walles commented 11 months ago

First:

Merging those should be easy, harmless and demonstrate good faith in solving moarvm's naming conflict. Even if the moarvm binary would never actually be renamed to moarvm.

After those changes have been merged I will happily approve of this.

halostatue commented 11 months ago

I will not be doing that, and I think that you vastly overestimate the importance of a pager as compared to a VM that powers language ecosystems. There is no moarvm naming conflict, there is a moar-pager naming conflict. This patch has been offered in the same way that I developed the moar +pager variant for MacPorts users: a way to help users. Either accept this patch and help your users or don’t. I really don't care what you do, but I’m done trying to help you serve your users better.