walles / riff

A diff filter highlighting which line parts have changed
MIT License
253 stars 5 forks source link

failed to rebuild 3.3.4 against rust 1.82.0 #67

Closed chenrui333 closed 2 weeks ago

chenrui333 commented 2 weeks ago

seeing some rebuild failure while regression build 0.16.0 against rust 1.82.0

  error: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead
     --> src/main.rs:261:38
      |
  261 | fn panic_handler(panic_info: &panic::PanicInfo) {
      |                                      ^^^^^^^^^
      |
  note: the lint level is defined here
     --> src/main.rs:6:9
      |
  6   | #![deny(warnings)]
      |         ^^^^^^^^
      = note: `#[deny(deprecated)]` implied by `#[deny(warnings)]`

  error: use of deprecated type alias `std::panic::PanicInfo`: use `PanicHookInfo` instead
     --> src/main.rs:435:51
      |
  435 |     panic::set_hook(Box::new(|panic_info: &panic::PanicInfo| {
      |                                                   ^^^^^^^^^

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/11421434685/job/31779323145#step:3:11460

relates to https://github.com/Homebrew/homebrew-core/pull/194802

chenrui333 commented 2 weeks ago

cc @walles

walles commented 2 weeks ago

This should now work with 3.3.5.

chenrui333 commented 2 weeks ago

thanks @walles!

relates to https://github.com/Homebrew/homebrew-core/pull/195357