Please add Ripple (XRP) to the wallet generator.

walletgeneratornet / WalletGenerator.net

Universal JavaScript Client-Side Wallet Generator

http://walletgenerator.net/

644 stars 558 forks source link

Please add Ripple (XRP) to the wallet generator. #132

Open pantuchy opened 6 years ago

pantuchy commented 6 years ago

Hello. Is it possible to add Ripple (XRP) to the wallet generator? Thank you.

ishan1608 commented 6 years ago

@MichaelMure I am trying to add the support for XRP. I am following https://github.com/MichaelMure/WalletGenerator.net/wiki/How-to-add-a-new-currency

ishan1608 commented 6 years ago

@MichaelMure When I tried to run Bitcoin.Address.decodeString('rhXFmLN2XndRAus8Azc7yESHPihG7bm4km') I got an error. I think it means Ripple cannot be added as it's addresses format is different than what this project supports. I guess we should close this issue mentioning that the support will not be added.

hemiipatu commented 6 years ago

Hmm this is really sad if that is the case, I had personally hoped that it might be added to the project as well. This project is by far, THE BEST for paper wallets.

hurlenko commented 6 years ago

Ripple uses custom base58 dictionary, it's not likely that ripple will be added to this generator