user provided paper wallet

[amahlaka]

After some fidling around with the source, i was able to add ZEC support ( at least the art for paper wallets) the address generation wont work as the address is longer and whatnot i was also ablo to use console commands to generate a paperwallet with my own keys and i think there should be a feature to: manually generate a paper wallet art, where you choose a currency that is not supported by the generator, then type in your own public and privatekey you have from your wallet and it generates a wallet with the art

[MichaelMure]

Did you follow https://github.com/MichaelMure/WalletGenerator.net/wiki/How-to-add-a-new-currency ?

If the address format or the crypto behind is different, I won't support this currency, sorry. I don't want to risk introducing bugs for the other currencies.

Adding new feature is also not a priority for me as I'm working on another project: https://github.com/MichaelMure/TotallyNotArbore

[amahlaka]

I did follow the guide, and came to conclusion that it is not compatible, that's why i proposed a way to support not creation of new addresses, but a "manual entry mode" where you select currency that is not supported by the crypto core, and paste in your own public and private keys and it generates QR codes and the wallet art It can be already done by Dev console, if have time, o can try to make the manual entry support for some currencies Because paper wallets are nice

On Thu, Jun 15, 2017, 8:42 AM Michael Muré notifications@github.com wrote:

Did you follow https://github.com/MichaelMure/WalletGenerator.net/wiki/How-to-add-a-new-currency ?

If the address format or the crypto behind is different, I won't support this currency, sorry. I don't want to risk introducing bugs for the other currencies.

Adding new feature is also not a priority for me as I'm working on another project: https://github.com/MichaelMure/TotallyNotArbore

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/MichaelMure/WalletGenerator.net/issues/57#issuecomment-308634468, or mute the thread https://github.com/notifications/unsubscribe-auth/ANSO_FYZRY8nIGNhtpbdZQbltfz6SfXbks5sEMRRgaJpZM4N6NQ- .

[amahlaka]

@MichaelMure i made initial version, available here: https://github.com/amahlaka/WalletGenerator.net go to paper wallet, type in zcash to Currency name and some random public and private keys, it should live change the art and qr codes, its only a initial version of the feature

[amahlaka]

note: no modifications done to parts that touch anything about address generation, just a bunch of dirty frontend modifications

[MichaelMure]

I opened a pull-request for your changes: https://github.com/MichaelMure/WalletGenerator.net/pull/58

[amahlaka]

@MichaelMure hmm, weird, the css is acting weird, on the site, all the leements of the manual paperwallet are all over the place, but when i click print, it shows them in correct places if i fix the look on site, it breaks the look on print

[amahlaka]

okay, thats fixed, i hope its working for you as well now

[amahlaka]

well, i got little carried away, i added support for manual Ethereum wallets, following the offical styleguide

[fredfalcon]

When running the first command to get the network version of Zcash - I get: Uncaught Checksum validation failed!

[MichaelMure]

That means that ZCash use a different crypto scheme than most of the currencies and cannot be supported by WalletGenerator

[fredfalcon]

This will do the trick - https://github.com/MichaelMure/WalletGenerator.net/pull/58

[terryxsq]

to support generating ZEC public address from private keys we need to change the way the code adds the network versions. so in the janin.currency.js i added this: janin.currency.createCurrency ("Zcash", [0x1c,0xb8], 0x80, "5", "[LK]" , ""),

then in the Bitcoin.Address.prototype.toString function we need to add the network version array instead of just unshift it into the byte array. so i am using the following var networkVersion = janin.currency.networkVersion(); if (networkVersion instanceof Array) { hash = networkVersion.concat(hash); } else { hash.unshift(networkVersion); }

[MichaelMure]

Hey Do you have a documentation that explain this address scheme somewhere ? Any idea about how widespread it is or the reason why it's different than bitcoin scheme ? How did you find out about this ?

[terryxsq]

for the zcash address to start with t1 it is stated in the faq. https://z.cash/support/faq.html t1 is for single key address and t3 is for multi key address. zcash is a fork of bitcoin so the address is derived the same way except you add t1 infront instead of 1. i have checked the address using the client and the address is the same.

for details you can read https://github.com/zcash/zips/blob/master/protocol/protocol.pdf page 31 which has the address details.

[MichaelMure]

ZCash is now supported.

[hank]

Can you add support for z-addrs? If I'm going to make a zcash paper wallet, it might as well use a Z address rather than a transparent address. Otherwise, what's the point of zcash??

[terryxsq]

this is for all address similar to btc address format. the Z private addr of zcash is different so probably not supported