search

walleth / walleth

free (libre) native Android Ethereum wallet
https://walleth.org
GNU General Public License v3.0
607 stars 175 forks source link

Support BIP39 passphrases #323

Open jgaa opened 5 years ago

jgaa commented 5 years ago

I am experimenting with import / export of BIP32/39/44 wallets supporting ETH.

I am using https://iancoleman.io/bip39/ to generate keys and expected ETH addresses.

When I import ETH keys with WallETH, using BIP39 mnemonics and no BIP39 passphrase, the ETH address shown by WallETH is correct. However, if I generate a seed using a BIP39 passphrase, and then import it with BIP39 mnemonic and also add the passphrase in the accompanying "password" field in WallETH, it generates the same Ethereum address as it does when no password is given. I seems like the entered password is not used to generate the seed for the keys.

This means that WallETH is unable to import wallets / keys from wallets that use the BIP39 passphrase.

ligi commented 5 years ago

Thanks for the feedback. You are correct - currently BIP39 passphrases are not supported - will add this feature.