feat: use JWT for topic subscription

wallforfry / dart_mercure

Dart library for dunglas/mercure

BSD 2-Clause "Simplified" License

13 stars 4 forks source link

feat: use JWT for topic subscription #3

Closed cawolf closed 4 years ago

cawolf commented 4 years ago

Hey,

thanks for this great package! When experimenting with it, I found that the JWT is not used for topic subscription. Since I want to disable ALLOW_ANONYMOUS in my project using Mercure, I decided to provide this PR.

This PR:

uses the JWT for both subscribe and publish
adds a GitHub Action workflow for automated testing and analysis

Please have a look at it and give me some feedback.

Thanks, best @cawolf

wallforfry commented 4 years ago

Hi @cawolf !

I'm happy to merge this PR. I just made some changes on syntax in the example. I'll create a new release 0.2.0 and push this to pub.dev asap.

Thanks for your contribution!

wallforfry commented 4 years ago

The 0.2.0 is now on pub.dev