search

walling / unorm

JavaScript Unicode 8.0 Normalization - NFC, NFD, NFKC, NFKD.
http://git.io/unorm
Other
379 stars 45 forks source link

Typo error in unorm object #35

Closed enna closed 9 years ago

enna commented 9 years ago

Hello,

This is a minor issue. In the unorm.js file, there is an unexpected comma after the last property of the unorm object. It is at line 383 in the current version on master branch : https://github.com/walling/unorm/blob/master/lib/unorm.js

Thanks :)

phadej commented 9 years ago

Have you some very old browser failing on that?

(that comma is totally valid JavaScript)

enna commented 9 years ago

Indeed, it works on ES5 browsers. There are many valid things in JavaScript that are not right to do, but good practices are subjective and this is your lib.

phadej commented 9 years ago

It's not technically mine, I'm just a collaborator. Ping @walling :)

phadej commented 9 years ago

Btw. you can link directly to the line (click the line number). Then if you press y, you get the link to the actual commit (url in the address bar changes): https://github.com/walling/unorm/blob/d5465c78933597e268a4606b5c9501789d892d07/lib/unorm.js#L383 #pro-tip

enna commented 9 years ago

Ok. Thanks for the tip. :)