Uglified version crashes in IE8

walling / unorm

JavaScript Unicode 8.0 Normalization - NFC, NFD, NFKC, NFKD.

http://git.io/unorm

Other

379 stars 45 forks source link

Uglified version crashes in IE8 #42

Open mlarcher opened 9 years ago

mlarcher commented 9 years ago

unorm fails on reduceRight in IE8, preventing all following code from running when in concatenated bundle. cf https://developer.mozilla.org/fr/docs/Web/JavaScript/Reference/Objets_globaux/Array/reduceRight#Browser_compatibility

mlarcher commented 9 years ago

any ETA for a fix on this issue ? It seems to me it is just a matter of implementing an IE8 compatible function that would emulate reduceRight.

walling commented 9 years ago

I'm inclined to not solve this. I think it's reasonable to include shims (reduceRight) for IE8 support, since the user base is quite small and declining. I don't want to increase the code size too much to support IE8. Maybe it should be better documented.

On the other hand, if you have time to submit a PR that removes the dependency on reduceRight it might be a good solution, and I will be happy to merge it. Have you tested that the reduceRight shim solves the issue?