wallix / awless

A Mighty CLI for AWS
http://awless.io/
Apache License 2.0
4.98k stars 263 forks source link

support passing extra args to ssh #118

Closed justone closed 1 year ago

justone commented 7 years ago

This adds support for passing extra args straight through to the ssh process, in a similar fashion to how vagrant does it. Here are a few use-cases:

simcap commented 7 years ago

Sorry for the delay here, we were getting the v0.1.1 out!

This sounds good but we are in the process of doing that through another approach and therefore adding more features (as you mentioned):

Those features will be done using the Golang ssh lib therefore not passing all args through but rather controlling and securing through the fully featured lib.

We can see when we have those features out, what is missing.

Also although not always practical but by doing for instance:

$(awless ssh myinstance --print-cli) -vvvv

any extra args can be added to the SSH client process.

justone commented 7 years ago

Interesting. Good to know about the future direction.

Out of curiosity, are you planning on keeping the "local exec" stuff (where the real ssh binary is used by default and the Go SSH lib is only a fallback) or switching to using just the lib? The reason I ask is that the SSH connection that the lib provides doesn't handle control characters or things like backspace and arrow keys and was basically unusable when I tried it out. I did a bit of research into it and this stackoverflow answer may help make it better, but having the option of using the real SSH client would still be useful, even if the order of preference is switched.

Your workaround (using the $(...)) is definitely awkward. I can put it in a shell function, but it's much nicer to just use the awless command line directly. Hopefully after the dust settles, we can still work something like this in.

Thank you.