wallix / awless

A Mighty CLI for AWS
http://awless.io/
Apache License 2.0
4.98k stars 263 forks source link

Allow using private ip for ssh #151

Closed luisdavim closed 5 years ago

luisdavim commented 6 years ago

for example, this command works:

awless ssh centos@i-0ab502440010ce2ed --through=dev-bastion

but if I try:

awless ssh centos@10.0.0.1 --through=dev-bastion

I get:

[error]   instance '10.0.0.1' not found

though 10.0.0.1 is the private ip for i-0ab502440010ce2ed and that is what it will be used for the connection anyway.

simcap commented 6 years ago

@luisdavim Thanks for spotting it. Fixing that.

simcap commented 6 years ago

Available in master as for now (go get -u ....)

luisdavim commented 6 years ago

Awesome. Thanks.

varunchandak commented 6 years ago

One more thing I would like to add that if the instance has private IP only, then --private parameter should not be required, and it should resolve that automatically. Correct me if I am wrong ?

fxaguessy commented 6 years ago

That would be indeed a nice improvement. I reopen this issue to track the implementation of this enhancement.

varunchandak commented 6 years ago

@fxaguessy can we get this too: image