search

wallix / webauthn

node.js webauthn framework
Apache License 2.0
105 stars 23 forks source link

Type declarations #16

Open eheikes opened 5 years ago

eheikes commented 5 years ago

We're consuming @webauthn/server in a TypeScript-based project. Is there interest in adding and maintaining type declarations (a .d.ts file) for that API in this project, or should we add them to DefinitelyTyped and keep them separate?

Kmaschta commented 4 years ago

Both would be a great addition! Ideally, it's better to include that in the module itself. Contributions are more than welcome!

P4sca1 commented 4 years ago

How about writing the library in typescript? This avoids the hassle of manually keeping the type declarations in sync and comes with the benefits of writing TypeScript.

eheikes commented 4 years ago

How about writing the library in typescript? This avoids the hassle of manually keeping the type declarations in sync and comes with the benefits of writing TypeScript.

Totally agree. The downside is that it adds friction for non-TS developers who want to work on the project, which the maintainers may not want.