search

wallix / webauthn

node.js webauthn framework
Apache License 2.0
105 stars 23 forks source link

android-safetynet #24

Open tnokin opened 4 years ago

tnokin commented 4 years ago

I used this lib to implement a fingerprint login on Android+Chrome. But then I received "android-safetynet" value in server/src/registration.js, where there is only "fido-u2f" and "packed" supported. So I forked and added the the option (but I'm no expert). Might be useful to others.

What I don't understand is why no one else had the issue ? Did I do smthg wrong on the client ?

Also I can't get this to work on Chrome on Windows. More exactly the fingerprint options is not proposed, only the security key. I feel this is more related to Windows than to the lib but I'd like to hear if someone has succeded using this on Windows ?

Kmaschta commented 4 years ago

Hi @tnokin,

This library was released to fulfill the needs of an authentication with a FIDO2 key only. All other authentication methods weren't implemented. See the roadmap at the end of the README:

image

To my knowledge, it is not planned to implement the support of the other authentication methods any time soon. But this repository is open-source, feel free to contribute!

eheikes commented 4 years ago

@tnokin Take a look at PR #26 and see what you think... I took some code from your fork and incorporated it with my code.