walmartlabs / generator-thorax

Thorax yeoman generator
MIT License
87 stars 27 forks source link

Bootstrap option needs to inform public/index.html of it's presence #46

Closed eriktrom closed 11 years ago

eriktrom commented 11 years ago

In other words, the files are copied to public/css and public/js but not included on the page

This also needs to be fixed for the production build. Not because it needs to be included on the page(main.js and screen.css are only src'd) but b/c the files are not in the path of the build tools, aka, app/js, app/css...

There's likely to be some overlap in implementation here, find the abstraction. Adding an external css or js file shouldn't require so many changes in so many places.

eriktrom commented 11 years ago

no it doesn't not, not when using https://npmjs.org/package/grunt-include-bootstrap, which will be part of #12

will collab with @kenwheeler on this