search

walmartlabs / generator-thorax

Thorax yeoman generator
MIT License
87 stars 27 forks source link

Rename root "main.js" file to index.js #87

Closed eastridge closed 10 years ago

eastridge commented 10 years ago

Was super confusing to tell people which "main.js" they needed to edit.

eriktrom commented 10 years ago

i totally agree, the ambiguity with require js files is the reason i haven't added it yet to the README

that said, the require js 'default' is name these files main... In general, i don't think very many people totally get require js though, and more people do understand this is how it's done in node, so let's do it.

@eastridge - question i have is should i rename js/main.js -> js/index.js test/main.js -> test/index.js

seems like that would be the convention then. But that doesn't seem to buy much in clarity, i'll think about this problem and perhaps look at what the community at large has taken to doing -- i'm also curious about our audience here... if everyone knew require js front to back this wouldn't be an issue, but no one does... so what do they know front to back is the question and how can we take those conventions and bring them here... hmmmm.. your suggestions seems to hint at node -- which is 'better' for sure...

eastridge commented 10 years ago

Hrmm....... Let's keep js/main and test/main the same. Maybe require-config.js for root main? It's explicit.