walmartlabs / lacinia-pedestal

Expose Lacinia GraphQL as Pedestal endpoints
http://lacinia-pedestal.readthedocs.io/en/latest/
Other
200 stars 63 forks source link

Update to io.pedestal libraries version 0.5.7 #95

Closed ivarref closed 4 years ago

ivarref commented 4 years ago

Hi

And thanks for a fine set of libraries!

Would it be possible to upgrade to pedestal 0.5.7 and make a new release?

I've recently-ish switched to java 11, and currently lacinia-pedestal 0.13.0-alpha-1 produces

WARNING: An illegal reflective access operation has occurred
WARNING: Illegal reflective access by org.eclipse.jetty.util.BufferUtil (file:/home/ire/.m2/repository/org/eclipse/jetty/jetty-util/9.4.0.v20161208/jetty-util-9.4.0.v20161208.jar) to field java.nio.MappedByteBuffer.fd
WARNING: Please consider reporting this to the maintainers of org.eclipse.jetty.util.BufferUtil
WARNING: Use --illegal-access=warn to enable warnings of further illegal reflective access operations
WARNING: All illegal access operations will be denied in a future release

during startup of the web server.

Overriding pedestal to 0.5.7 solves this problem.

Edit: These problems popped up with java 9 and is a general problem for "old" libraries: https://clojure.org/guides/faq#illegal_access

Thanks and kind regards!

hlship commented 4 years ago

No particular reason not to switch and, of course, you can easily override the dependency in your project.clj.

hlship commented 4 years ago

Fixed by 2a2ecb2abb4accd00058a3dd6169288dd7d6129c