search

walmartlabs / lacinia

GraphQL implementation in pure Clojure
http://lacinia.readthedocs.io/en/latest/
Other
1.81k stars 160 forks source link

Initial board game schema in tutorial missing `non-null` for ID #180

Closed xiongtx closed 6 years ago

xiongtx commented 6 years ago

The initial schema has BoardGame ID like:

{:BoardGame
  {:description "A physical or virtual board game."
   :fields
   {:id {:type ID}
   ...}}}

whereas it should be 

{:id {:type (non-null ID)}
   ...}

The non-null magically appears in a later version of the schema ✨.

I don't see a resources/cgg-schema.edn anywhere in Lacinia itself; otherwise this is a trivial fix.

hlship commented 6 years ago

Fixed.