search

walmartlabs / lacinia

GraphQL implementation in pure Clojure
http://lacinia.readthedocs.io/en/latest/
Other
1.82k stars 160 forks source link

Fix error when merging lists in fragments #452

Closed tom-riverford closed 8 months ago

tom-riverford commented 8 months ago

We noticed some exceptions being thrown after upgrading from 0.38.0 to 1.0

It seemed that when there is a list field both on an object and in a fragment, lacinia was attempting to do a map merge on the lists.

I've added a test which simulates the problem we had, and modified internal-utils/deep-merge so that it works on maps, sequentials and any other values.

CLAassistant commented 8 months ago

CLA assistant check
All committers have signed the CLA.