search

walmartlabs / little-loader

A lightweight, IE8+ JavaScript loader
MIT License
370 stars 28 forks source link

switching to jwt for sauce labs #43

Closed halkeye closed 7 years ago

halkeye commented 8 years ago

If my eyeballed yaml is right, this will fix #42

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-38.2%) to 61.818% when pulling a4d41bbc07b52de5f341324caa624c314b1649f8 on halkeye:patch-1 into da95af545deb0f3aaa3da0a6fcd5d7d65f233abf on walmartlabs:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-38.2%) to 61.818% when pulling 002571747fd8d4fe59f48e97811ba744b4c56c0d on halkeye:patch-1 into da95af545deb0f3aaa3da0a6fcd5d7d65f233abf on walmartlabs:master.

halkeye commented 8 years ago

:( i'll have to look into this

ryan-roemer commented 8 years ago

@halkeye -- https://github.com/walmartlabs/little-loader/pull/44 passed in a branch with 

addons:
  jwt:
    - secure: SECRETSECRETSECRET
  sauce_connect: true
halkeye commented 8 years ago

yea, but thats your own branch thing. That kinda confirms my suspicion, somehow sauce_connect isn't whitelisted for prs properly

coveralls commented 8 years ago

Coverage Status

Coverage remained the same at 100.0% when pulling 4ba531009f180d0c7948db320cc43267280666d5 on halkeye:patch-1 into da95af545deb0f3aaa3da0a6fcd5d7d65f233abf on walmartlabs:master.

ryan-roemer commented 8 years ago

yea, but thats your own branch thing

My intention with the branch is to confirm the structure of the config is correct and can actually provide the secret in the "most privileged" case.

No ideas as to the internals / how whitelisting works, but just let me know if there are any experiments / etc. we can do for you...

halkeye commented 8 years ago

Yep thanks

I tried documenting it all https://github.com/travis-ci/travis-ci/issues/6569

:( I really thought we had this working, was so excited

ryan-roemer commented 8 years ago

@geekdave @Maciek416 -- Keep an eye on this branch. It looks like the sauce_connect PR thing is "almost there" but not quite yet...

halkeye commented 8 years ago

:D To defend it, JWT is working fine, sauce_connect addon isn't :D but i agree

ryan-roemer commented 8 years ago

@halkeye -- Updated my comment 😉 Apologies for the lack of precision and thanks for all this work (and happy to help dogfood it here)

ryan-roemer commented 7 years ago

Rebuilding https://travis-ci.org/walmartlabs/little-loader/builds/158195834 per comment https://github.com/travis-ci/travis-ci/issues/6569#issuecomment-253588881 to see if external PR passes now.

halkeye commented 7 years ago

retesting!

halkeye commented 7 years ago

@ryan-roemer LOOOOK!

ryan-roemer commented 7 years ago

@halkeye -- Yep! (I actually just manually restarted the build before your newline commit). Weirdly, I don't see CI status in this PR anymore...

Can you revert the extra newline and then I'll merge. Thanks for all your work!

halkeye commented 7 years ago

yea I'm not sure why the CI status stuff isn't working. I'm suspicious that github's webooks hare delayed.

halkeye commented 7 years ago

I kinda want to re-create this branch to confirm everything works

but i also know everything works from the daily motion build.

ryan-roemer commented 7 years ago

@halkeye - that might actually be a good idea. I leave it up to you if you want to close this PR and just do a new one from scratch or if you want me to merge this one.

BanzaiMan commented 7 years ago

Sometimes Travis CI fails to post a status to commits for one reason or another. Could you try pushing another commit?

halkeye commented 7 years ago

Yea for sure, as soon as I get a minute on my laptop.

I don't think it's Travis fault. The last two.commits are not showing up under the pr tab on Travis either

halkeye commented 7 years ago

:( i'm not sure why its not picking up the changes.

halkeye commented 7 years ago

@BanzaiMan yea, none of the new ones are showing up at https://travis-ci.org/walmartlabs/little-loader/pull_requests