search

walmartlabs / little-loader

A lightweight, IE8+ JavaScript loader
MIT License
370 stars 28 forks source link

Add `{callback, setup, context}` options as alternative to `callback`. #50

Closed ryan-roemer closed 7 years ago

ryan-roemer commented 7 years ago

Extra commits on top of @jknight12882 's excellent https://github.com/walmartlabs/little-loader/pull/49

@jknight12882 -- I can either keep going with this and squash the whole thing down (which would lose your git commit attributions, but we've got your name in HISTORY), or you can rebase your PR with these changes and we'll keep going on #49

@exogen -- How do all these changes look together? Any pitfalls we're missing?

ryan-roemer commented 7 years ago

@exogen -- Also note that all of our Travis builds were disabled for all walmartlabs repos weirdly. I've started reenabling the ones we currently use. You may want to peek at other repos under walmartlabs...

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling d626e59e86dfd32b4957ce764a2743f44517c37e on feature-options into \ on master**.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 091d3f323ee30c93ea08bd483d363c6888e2c415 on feature-options into \ on master**.

jknight12882 commented 7 years ago

No need to keep my git history. Squash away!

ryan-roemer commented 7 years ago

@jknight12882 -- Great! (We're just waiting on @exogen to finish up his PTO and approve this, then I'll publish)

ryan-roemer commented 7 years ago

Released in little-loader@0.2.0