Adding types to the callback comment section

walmartlabs / little-loader

A lightweight, IE8+ JavaScript loader

MIT License

370 stars 28 forks source link

Adding types to the callback comment section #55

Closed rubenspgcavalcante closed 6 years ago

rubenspgcavalcante commented 6 years ago

Closes #54

CLAassistant commented 6 years ago

Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

rubenspgcavalcante commented 6 years ago

Ok, I'm closing this as it too much to make this simple contribution. The need to sign a contract + plus provide personal information like full name and address to just two lines on the README is waaaay to much lol

I'm sure that you guys can do this internally

ryan-roemer commented 6 years ago

Thanks for the work @rubenspgcavalcante !

I'm unfortunately not a maintainer on the project anymore. (I contracted with Walmart Labs a while back when we originally wrote this).

@jchip -- perhaps you or the active Walmart Labs team can pick this doc change up? I think it's a valuable addition 😄