search

walmartlabs / ridicule

Mocking everything
MIT License
22 stars 8 forks source link

Add remaining test coverage #7

Closed kpdecker closed 10 years ago

kpdecker commented 10 years ago

Fixes a few bugs in the process and cleans a few of the APIs.

  1. Clarifies the restrictions on the ridiculeSettings return object
  2. Fixes query handling in bailout
  3. Prevents side effects from mock registration (mostly only matters for tests)
kpdecker commented 10 years ago

@patrickkettner I'm assuming that the lack of comments is approval here. Merging so we can continue to make progress on this project.

patrickkettner commented 10 years ago

the lack of comments was due to a family emergency. didn't realize you needed this merged so quickly

kpdecker commented 10 years ago

Please feel free to comment if you see anything, but per the other ones, I'd like to leave style concerns to yourself to fix as you see fit.

patrickkettner commented 10 years ago

Released in 1.0.0