search

walmartlabs / thorax

Strengthening your Backbone
http://thoraxjs.org/
Other
1.32k stars 129 forks source link

$el not set occasionally in handleChangeFromEmptyToNotEmpty and handleChangeFromNotEmptyToEmpty #352

Closed patrickkettner closed 10 years ago

patrickkettner commented 10 years ago

An issue that seems to be cropping up is 'undefined' is not an object (evaluating 'e.removeAttr') and 'undefined' is not an object (evaluating 'e.attr')

tracked it back to here and here.

haven't found it replaceable, but is happening regularly.

kpdecker commented 10 years ago

I'm seeing this in one view that is trying to render a collection against a non-collection. This might be an issue with the renderCollection call. Will open an internal PR to discuss that there.

Leaving this open for now while we figure that out.

On Wed, Apr 2, 2014 at 4:17 PM, patrick kettner notifications@github.comwrote:

An issue that seems to be cropping up is 'undefined' is not an object (evaluating 'e.removeAttr') and

— Reply to this email directly or view it on GitHubhttps://github.com/walmartlabs/thorax/issues/352 .

kpdecker commented 10 years ago

This is an application-level issue, the view in question was using renderCollection but was not a CollectionView instance.