search

walmartlabs / thorax

Strengthening your Backbone
http://thoraxjs.org/
Other
1.32k stars 129 forks source link

update docs to point at walmartlabs/generator-thorax #380

Closed eriktrom closed 9 years ago

eriktrom commented 9 years ago

update docs to point at walmartlabs/generator-thorax

/cc @eastridge

eastridge commented 9 years ago

@trombom can you force travis to rebuild as it failed? Also, can you push the generated docs to the hg-pages branch?

eriktrom commented 9 years ago

@eastridge - pushed gh-pages w/ the above docs @kpdecker - CI seems mad, is it me?

eriktrom commented 9 years ago

HALP! :)

Running "saucelabs-mocha:zepto" (saucelabs-mocha) task
=> Starting Tunnel to Sauce Labs
>> ** This version of Sauce Connect is outdated.** Please update with https://saucelabs.com/downloads/Sauce-Connect-3.1-r32.zip
>> 2014-08-09 09:40:11.697:INFO::jetty-7.x.y-SNAPSHOT
>> 2014-08-09 09:40:11.724:INFO::Started SelectChannelConnector@0.0.0.0:46109
>> 2014-08-09 09:40:32.993:INFO::jetty-7.x.y-SNAPSHOT
>> 2014-08-09 09:40:32.997:INFO::Started SelectChannelConnector@0.0.0.0:4445
>> Connected to Saucelabs
1 / 10 tests started
2 / 10 tests started
3 / 10 tests started
4 / 10 tests started
5 / 10 tests started
Tested http://localhost:9999/zepto-backbone-1-0/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto-backbone-1-0/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto-backbone-1-0/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto-backbone-1-0/test.html
Platform: undefined
>> Test Error
Url undefined
6 / 10 tests started
7 / 10 tests started
8 / 10 tests started
9 / 10 tests started
10 / 10 tests started
Tested http://localhost:9999/zepto/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto-backbone-1-0/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto/test.html
Platform: undefined
>> Test Error
Url undefined
Tested http://localhost:9999/zepto/test.html
Platform: undefined
>> Test Error
Url undefined
>> All tests completed with status false
=> Stopping Tunnel to Sauce Labs
Warning: Task "saucelabs-mocha:zepto" failed. Use --force to continue.
kpdecker commented 9 years ago

Rebase, the tests should hopefully be fixed.

On Sat, Aug 9, 2014 at 5:11 AM, Erik Trom notifications@github.com wrote:

HALP! :)

Running "saucelabs-mocha:zepto" (saucelabs-mocha) task => Starting Tunnel to Sauce Labs

* This version of Sauce Connect is outdated.* Please update with https://saucelabs.com/downloads/Sauce-Connect-3.1-r32.zip 2014-08-09 09:40:11.697:INFO::jetty-7.x.y-SNAPSHOT 2014-08-09 09:40:11.724:INFO::Started SelectChannelConnector@0.0.0.0:46109 2014-08-09 09:40:32.993:INFO::jetty-7.x.y-SNAPSHOT 2014-08-09 09:40:32.997:INFO::Started SelectChannelConnector@0.0.0.0:4445 Connected to Saucelabs 1 / 10 tests started 2 / 10 tests started 3 / 10 tests started 4 / 10 tests started 5 / 10 tests started Tested http://localhost:9999/zepto-backbone-1-0/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto-backbone-1-0/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto-backbone-1-0/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto-backbone-1-0/test.html Platform: undefined Test Error Url undefined 6 / 10 tests started 7 / 10 tests started 8 / 10 tests started 9 / 10 tests started 10 / 10 tests started Tested http://localhost:9999/zepto/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto-backbone-1-0/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto/test.html Platform: undefined Test Error Url undefined Tested http://localhost:9999/zepto/test.html Platform: undefined Test Error Url undefined All tests completed with status false => Stopping Tunnel to Sauce Labs Warning: Task "saucelabs-mocha:zepto" failed. Use --force to continue.

— Reply to this email directly or view it on GitHub https://github.com/walmartlabs/thorax/pull/380#issuecomment-51682819.

eriktrom commented 9 years ago

lol... rebased and looks like saucelabs works, and well...

must pass parent depths for child view block helper with {{../root}} inside - i looked at the code, wasn't trivial for me or I would just fix :)

kpdecker commented 9 years ago

That most recent issue was due to better error checking in the latest handlebars release. I should get the thorax test fixes (we're dropping support for SSJS restore in that case) this evening/tomorrow.

kpdecker commented 9 years ago

Fix in master. I went ahead and merged this as the tests don't really apply to the readme.

On Thu, Aug 28, 2014 at 11:10 PM, Erik Trom notifications@github.com wrote:

lol... rebased and looks like saucelabs works, and well...

must pass parent depths for child view block helper with {{../root}} inside - i looked at the code, wasn't trivial for me or I would just fix :)

— Reply to this email directly or view it on GitHub https://github.com/walmartlabs/thorax/pull/380#issuecomment-53835471.