walmartlabs / walmart-cla

Walmart Contributor License Agreement Information
Apache License 2.0
85 stars 35 forks source link

Activating CLA Assistant #24

Closed mosabua closed 6 years ago

mosabua commented 6 years ago

This issue is created to notify everyone in the walmartlabs and walmart github organizations about the activation of CLA assistant.

Please review the information on the walmart internal website https://sde.walmart.com/blog/2018-01-22-cla-made-easy.html as well as the readme of this repository.

Notification to all members will go out via github notifications and CLA assistant will be activated shortly.

walmartlabs-cla-admin commented 6 years ago

CLA assistant is now activated on both orgs.

andersjanmyr commented 6 years ago

@mosabua Why do you require this much access? It seems excessive to me.

mosabua commented 6 years ago

CLA assistant pre-filled the form to fill out with your user details and it needs to have the webhooks and other access so it can be an automatic step in each pull request in each repository.

walkerthompson commented 6 years ago

Manfred,

Why are we getting these emails in general?

Walker

mosabua commented 6 years ago

Please read the issue text and the linked docs. The new CLA procedure requires to have a signed CLA in the system and it applies to ALL contributors on ALL repositories in the organizations walmartlabs and walmart. It has been on trial and in use for the oneops and electrode-io organizations already. All repository owners also need to make sure that PRs are only merged if a CLA is signed. As such I needed to notify everyone in the orgs and the only way this can be done is by mentioning all users on an issue.

hlship commented 6 years ago

Is there a step involved at https://cla-assistant.io/ ? I started to do the "link" step there, but wasn't sure about what option to use for the "Choose a CLA".

mosabua commented 6 years ago

No .. you simply have to fill out the CLA form next time you submit a PR.. there will be a validation check and it will have a link in it. You do NOT need to do any configuration or link a repo.. thats all done already for the whole org.

hlship commented 6 years ago

Oh, there's options here: https://github.com/walmartlabs/walmart-cla.

I'm still missing something. Is there any additional step for me to do for the lacinia (https://github.com/walmartlabs/lacinia) and lacinia-pedestal (https://github.com/walmartlabs/lacinia-pedestal) libraries? Or are those already enabled for CLA checks because they are in walmartlabs?

mosabua commented 6 years ago

All repositories in this org are automatically configured and when you create your next PR you will see the CLA check. Here is an example of a PR in the oneops org with a passed CLA check

https://github.com/oneops/oneops/pull/337

If the check does not pass it adds a request to sign the CLA for the committer.

hlship commented 6 years ago

Ok, thanks!

amitkirdatt commented 6 years ago

Removing yourself from an organization: https://help.github.com/articles/removing-yourself-from-an-organization/

mosabua commented 6 years ago

Notifications went out to everyone now. We are proceeding with further steps internally.

mosabua commented 6 years ago

To further improve mgt of the orgs we are trying to establish username mappings and we would appreciate your help. Please check out https://sde.walmart.com/blog/2018-01-25-github-org-access.html (internal URL)