walnuthq / cairovm.codes

Source code for cairovm.codes — a web app to compile Cairo programs into Sierra and CASM with step-through execution capabilities.
https://cairovm.codes
MIT License
29 stars 24 forks source link

feat: Display call parameters in the callstack table #143

Closed barabanovro closed 2 months ago

barabanovro commented 2 months ago

The run API endpoint has been updated to return parameters within the callstack entries. These parameters can be found at callstack[execution_step][call_index].params.

Required Changes:

Parameters example:

[
   {
      "type_name":"RangeCheck",
      "value":[
         828
      ]
   },
   {
      "type_name":"GasBuiltin",
      "value":[
         9999999977109
      ]
   },
   {
      "type_name":"core::integer::u256",
      "value":[
         3,
         0
      ]
   },
   {
      "type_name":"core::integer::u256",
      "value":[
         5,
         0
      ]
   },
   {
      "type_name":"core::integer::u256",
      "value":[
         7,
         0
      ]
   }
]

We expect to see comma-separated Parameters row: 828, 9999999977109, [3, 0], [5, 0], [7, 0]

jaipaljadeja commented 2 months ago

hey i would like to do this, i recently did the virtualization changes, so i know where to add the column and rest.

melnikga commented 2 months ago

Can I take this?

BlackStarkGoku commented 2 months ago

Hi, I am a frontend software engineer that recently discovered starknet ecosystem! I really want and I am motivated to start doing my first contributions to the ecosystem, I would be honored to tackle this issue by looking at what the result of this API is about and making all changes needed !

barabanovro commented 2 months ago

Thank you everyone for your interest in working on this issue. I am assigning it to @melnikga, who has the capacity and relevant experience to address this promptly.