walnuthq / op-scan

Lightweight transaction explorer for the OP Stack.
7 stars 16 forks source link

Initial setup feedback #3

Closed mazurroman closed 1 week ago

mazurroman commented 2 weeks ago

opscan-logo-transparent

saimeunt commented 1 week ago

@mazurroman Logo has been updated accordingly in #4 Concerning the pnpm-lock.yaml inconsistencies, this may have to do with an outdated pnpm version on your end? (see https://github.com/pnpm/pnpm/issues/7934). Maybe we can update the README to specify a recommended version of pnpm >= 9 to avoid this problem in upcoming PRs, wdyt?

jaipaljadeja commented 1 week ago

@mazurroman Logo has been updated accordingly in #4 Concerning the pnpm-lock.yaml inconsistencies, this may have to do with an outdated pnpm version on your end? (see pnpm/pnpm#7934). Maybe we can update the README to specify a recommended version of pnpm >= 9 to avoid this problem in upcoming PRs, wdyt?

Yes! you are correct the inconsistencies comes because of different pnpm versions. To solve this problem you can mention the version of package manager in package.json

For example:

....
"packageManager": "pnpm@8.5.1"
...

Also you can add in README that people should enable corepack in Node and install pnpm using corepack (guide)

Next time whenever you will use pnpm in any project with packageManager present in package.json, Node will automatically install the required pnpm version (if not installed) and use it for the same project.

saimeunt commented 1 week ago

@jaipaljadeja Thanks for your comment, I didn't know about corepack and just found out, it's looking promising! While it's probably the way to go in the foreseeable future, corepack is still experimental and I want to keep the tech stack aligned with OP Stack so I don't want to introduce another requirement and I prefer to wait until broader adoption. Closing as pnpm >= 9 was added in the README.