search

walokra / markdown-page-generator-plugin

Markdown to HTML Page Generator Maven Plugin
MIT License
57 stars 48 forks source link

copyDirectories does not work with relative inputDirectory #33

Closed tdiesler closed 1 year ago

tdiesler commented 6 years ago

If found that this does not seem to copy the configured dirs

                <configuration>
                    <inputDirectory>docs</inputDirectory>
                    <headerHtmlFile>docs/html/header.html</headerHtmlFile>
                    <footerHtmlFile>docs/html/footer.html</footerHtmlFile>
                    <copyDirectories>css,img</copyDirectories>
                    <recursiveInput>true</recursiveInput>
                    <transformRelativeMarkdownLinks>true</transformRelativeMarkdownLinks>
                </configuration>

This however, does

                <configuration>
                    <inputDirectory>${basedir}/docs</inputDirectory>
                    <headerHtmlFile>${basedir}/docs/html/header.html</headerHtmlFile>
                    <footerHtmlFile>${basedir}/docs/html/footer.html</footerHtmlFile>
                    <copyDirectories>css,img</copyDirectories>
                    <recursiveInput>true</recursiveInput>
                    <transformRelativeMarkdownLinks>true</transformRelativeMarkdownLinks>
                </configuration>

IMHO, copyDirectories should also work with an relative input dir.

walokra commented 4 years ago

Do you mean relative input dir to basedir so as if not given the basedir would be injected to the configuration?

Pull Request is welcomed but I think that using the ${basedir} variable in the configuration is a robust solution and relative input dir for copyDirectories doesn't bring any new value.

tdiesler commented 1 year ago

out-of-date