search

walokra / markdown-page-generator-plugin

Markdown to HTML Page Generator Maven Plugin
MIT License
56 stars 48 forks source link

Enabling flexmark boolean options #41

Closed bmlong137 closed 4 years ago

bmlong137 commented 5 years ago

This is really difficult to design, but I needed flexmark options available here: https://github.com/vsch/flexmark-java/blob/master/flexmark/src/main/java/com/vladsch/flexmark/parser/Parser.java

These changes allow you to specify those options with a configuration element, but it assumes the type is boolean and assumes to set it to the default value as specified in that class.

I know it works with option LISTS_ORDERED_LIST_MANUAL_START. That option is required to make flexmark behave more like gitlab/github for lists.

Not sure how this should best be implemented for more generic cases. 95% of the fields are boolean though.

bmlong137 commented 4 years ago

any update on including this in master? does it need a rewrite?

walokra commented 4 years ago

I try to look into this later this week.

walokra commented 4 years ago

Tests pass so this doesn't seem to affect the original functionality and the Flexmark options feature can be included as it now is. Tests would be nice to have and some documentation.

mikecapito commented 3 years ago

Is it possible to configure all the boolean options on https://github.com/vsch/flexmark-java/wiki/Extensions? I saw you linked to this list of options on the release notes to this merge request, but I don't see how to configure them.

(Specifically I need to change then anchor tag from id= to name=, and there appears to be a configuration option to do that ... ANCHORLINKS_SET_NAME)

Thanks!

walokra commented 3 years ago

@mikecapito For now the support for Flexmark options is limited to Parser options and e.g. the ANCHORLINKS_SET_NAME. Pull requests are welcome if you want to add support for those.