Closed nodevel closed 9 years ago
Thanks for you pull req and the suggestions are nice. I merged the changes for the gallerydelegate (manually).
Have to think about the position of the toolbar. And e.g. if the toolbar is at the top, then silicaflickable is needed and also the smooth animation doesn't work correctly with combobox height. At the bottom it works differently.
There are more options, if you want to have the toolbar on top no matter what. One of the solutions can be my favorite:
SilicaGridView {
PullDownMenu {}
header: PageHeader {
ActionBar {}
}
}
Notice that it also removes the need for SilicaFlickable, but is now visible on top of the page only. On the other hand, you stated stat those actions are not primary, therefore it shouldn't be that much of a problem (you can always fast-scroll up).
Yep, there are many options and things may change when testing different outcomes. The toolbar has now setting to be at the top or at the bottom. For now the hiding isn't smooth as there's issues with combobox & changing height.
Hello, I have noticed you began your work on redesigning the main page, so I had a look at the code and created some improvements:
I hope you will like some of the changes. It is, of course, up to you to decide whether to include them or not. I can take a look at what can be improved at other pages (besides MainPage) if you do.