search

walokra / sailimgur

Imgur app for Sailfish OS.
http://ruleoftech.com/lab/sailimgur
GNU General Public License v3.0
10 stars 5 forks source link

Images aren't scaled with bigger screens #18

Closed DylanVanAssche closed 2 years ago

DylanVanAssche commented 8 years ago

When you click on a image the image is very small on bigger screen. This can be fixed by using the Screen.width and Screen.height property in QML when defining the size of the image.

walokra commented 8 years ago

Thanks for reporting this. The images in gallery are fetched as scaled (640x640 preserving aspect ratio) as it's the resolution in Jolla phone and if it's Jolla Tablet (or Screen is recognized as large) the images are fetched as original. That's done for performance reasons. So, the issue is with other phones running Sailfish OS with bigger screens.

For now, you can long press the image to see action buttons and open the original image.

I could add setting for getting original images (or in bigger scale) in albums which should resolve the issue. Not sure when I have time to do this.

DylanVanAssche commented 8 years ago

I will try it out and send you a pull request?

walokra commented 8 years ago

Of course PR is welcome :)

DylanVanAssche commented 8 years ago

I tried to build it but it seems that I don't have an API key or something. I just need to see an image to try it out...

QT console log:

[D] tryRefreshingTokens:142 - Permission denied. Trying to refresh tokens.
[D] showHttpError:96 - API error: code=400; message=Bad Request: Client id was not found in the headers or body. Can't refresh tokens. Please sign in again.

I need to fill them in in Constant.qml but where can I get them?

walokra commented 8 years ago

You can get the OAuth2 tokens from https://api.imgur.com/oauth2.

henk84 commented 2 years ago

AFAICT this issue is not correct for the latest version (I’m on the newest build for aarch64, if that is important). I’d assume it can be closed.