search

walokra / sailimgur

Imgur app for Sailfish OS.
http://ruleoftech.com/lab/sailimgur
GNU General Public License v3.0
10 stars 5 forks source link

Greatly simplified reddit integration in imgur.js #20

Closed tetris-11 closed 8 years ago

tetris-11 commented 8 years ago

Hi, I just did a quick fix of imgur.js that removes a lot of unneccesary code I added earlier and integrates much better with your original code base.

This also fixed the album issue I was having with some subreddits.

(Last edit I swear!)

walokra commented 8 years ago

Released 0.9.0 with the new subreddit mode. Available now from OpenRepos, later from Harbour.

tetris-11 commented 8 years ago

Excellent, you cleaned up my messy search integration too - much appreciated.

The floating subreddit TextField really should be fixed into the main column somehow. I wish I could help bit Silica is still a mystery to me.

Also, maybe it would benefit from being a text editable dropdown menu of previous searches?

Either way, thanks.

walokra commented 8 years ago

Thanks for the pull request, most of the work was already done :)

I thought about the floating TextField but decided to leave it where it was as the main column gets crowded. Will see how it works like that.

Storing the previous searches is good idea.

tetris-11 commented 8 years ago

It's a really great app -- can't wait to see future updates :-)