Project cleanup - Githubissues

walrusone / SkyWarsReloaded

SkyWarsReloaded

GNU General Public License v3.0

22 stars 52 forks source link

Project cleanup #57

Closed sgdc3 closed 6 years ago

sgdc3 commented 6 years ago

Enhanced the maven project structure
Removed eclipse project files
Enhanced the .gitignore config

walrusone commented 6 years ago

Thanks for the cleanup, long overdue!

sgdc3 commented 6 years ago

uh, damn merge conflicts, i'm sorry @walrusone

walrusone commented 6 years ago

No problem, I have it resolved now. I was working on adding team mode. My fault for not keeping the git current LOL

walrusone commented 6 years ago

Only found one issue so far, you imported the Spigot-API into all of the NMS classes. This created access to methods that aren't available across all versions (especially in 1.8 builds)

sgdc3 commented 6 years ago

@walrusone we can just remove it, won't provide javadocs and source code but i think it's fine.

sgdc3 commented 6 years ago

@walrusone Also, i added SkyWarsReloaded to my build server: https://ci.codemc.org/job/Walrusone/job/SkyWarsReloaded/

You can login using the github oauth and edit your build job as you want ;)