search

walt-id / waltid-walletkit

Toolkit for SSI and NFT/SBT wallets
https://docs.walt.id
Apache License 2.0
31 stars 25 forks source link

Bug - Endpoint /config/did/delete doesn't work #164

Closed Happy2C0de closed 11 months ago

Happy2C0de commented 1 year ago

Hi all

First of all, very great repository and interesting project! 👏 👍

Testing the API, I couldn't delete any created DID using the /issuer-api/ endpoint. I think there is a bug in the following line: IssuerController.kt#L79

Shouldn't it be as follows:

get("{id}", documented(DidController.loadDocs().describeTenantId(), DidController::load))
delete("{id}", documented(DidController.deleteDocs().describeTenantId(), DidController::delete))

I added the load functionality to extend the endpoint group.

cre8 commented 1 year ago

I think it's the same for Key Management, the id of the object is also missing there.

Looking up in the DidController function only the line mentioned by @Happy2C0de is missing

So fixing this via a PR should be easy

mikeplotean commented 11 months ago

fixed by https://github.com/walt-id/waltid-walletkit/pull/174