walt-id / waltid-walletkit

Toolkit for SSI and NFT/SBT wallets
https://docs.walt.id
Apache License 2.0
31 stars 25 forks source link

fix: pr174 #178

Closed mikeplotean closed 11 months ago

github-actions[bot] commented 11 months ago

Hey there and thank you for opening this pull request! 👋🏼

Some or all of your commit messages do not seem to follow the Conventional Commits specification. To allow the merge of this pull request, we require that at least one commit message or the PR title follow that convention.

You have the following possibilities to proceed with this PR: 1) Make sure at least one commit message complies with the Conventional Commits specification. Note, if not all messages comply, the merge will be allowed, but you will still see this warning. 2) Update the title of this pull request to comply with the Conventional Commits specification.

Further information: The commit messages and PR title will be parsed according to the Conventional Commits specification, to automatically populate the release notes for the next official release. Therefore, make sure the commit messages or PR title contain the necessary and relevant information describing the changes of this pull request.

Commit message details:

[
  {
    "hash": "615720998da6ff63eee3f228bf12a13cf03c03c4",
    "message": "chore: pr minor fixes",
    "valid": true,
    "errors": [],
    "warnings": []
  },
  {
    "hash": "c8efead33fd0baafa54fe22304bb2b96e453c8c6",
    "message": "fix: Set correct response type\n\nSigned-off-by: Mirko Mollik <mirkomollik@gmail.com>",
    "valid": false,
    "errors": [
      "subject must not be sentence-case, start-case, pascal-case, upper-case"
    ],
    "warnings": []
  },
  {
    "hash": "b9d17efbe753b5dd6d0110cbf5e7699c34104fa4",
    "message": "fix: Add missing endpoints for did, keys and vc",
    "valid": false,
    "errors": [
      "subject must not be sentence-case, start-case, pascal-case, upper-case"
    ],
    "warnings": []
  }
]

PR title details: