search

walter-cd / walter

Tiny deployment pipeline
http://walter-cd.net
Apache License 2.0
438 stars 39 forks source link

release 1.1.0 returns version v1.0.0-17-g2e53e91 #102

Closed sawanoboly closed 9 years ago

sawanoboly commented 9 years ago

Hi, I found that a binary which was provided via github returns incorrect version.

Such as below,

$ wget https://github.com/walter-cd/walter/releases/download/v1.1.0/walter_darwin_amd64.zip

$ unzip walter_darwin_amd64.zip 
Archive:  walter_darwin_amd64.zip
  inflating: walter_darwin_amd64/walter  
  inflating: walter_darwin_amd64/README.md  
  inflating: walter_darwin_amd64/LICENSE-HEADER.txt  
  inflating: walter_darwin_amd64/LICENSE.txt  

$ ./walter_darwin_amd64/walter -v
Walter version v1.0.0-17-g2e53e91

This issue is not important so much for us. Take your time.

takahi-i commented 9 years ago

Thank you very much for the report @sawanoboly! I will look into the problem.

takahi-i commented 9 years ago

I have replaced the walter binaries. Now the binaries output the expected version as expected.

$bin/walter -v
$Walter version v1.1.0
sawanoboly commented 9 years ago

Thanks!

$ walter -v
Walter version v1.1.0
takahi-i commented 9 years ago

great!