Add base_url support for hipchat2 private servers

swdunlop commented 9 years ago

This pull request addresses https://github.com/walter-cd/walter/issues/47 by adding support for HipChat on-premises (private) servers to the hipchat2 messenger by doing the following:

bumping the godep for https://github.com/tbruyelle/hipchat-go to match upstream v1.0, which exposes BaseURL
adding a configuration field to the hipchat2 messenger, base_url
documenting the change in the README.md

The other hipchat messenger also supports BaseURL in their client, as of https://github.com/andybons/hipchat/commit/0fd4d621380d2b040f1ee141c8653f3fc7346484 but it has not been tagged as a release, so I did not include version 1 support.

I have verified this change works with our on-premises server.

takahi-i commented 9 years ago

Thank you very much for the contribution @swdunlop ! :+1:

ainoya commented 9 years ago

LGTM :+1:

walter-cd / walter

Add base_url support for hipchat2 private servers #121