search

walter-cd / walter

Tiny deployment pipeline
http://walter-cd.net
Apache License 2.0
438 stars 39 forks source link

report_full_output #122

Closed ghost closed 9 years ago

ghost commented 9 years ago

Hello, I noticed that in function ReportStageResult (in pipelines/pipeline.go) there is a self.Reporter.Post on the second line of the function. This means that all stages will output to the messenger no matter how you config the pipeline.yml file. For myself, I want to control what is being sent out to my Slack client, especially if the build file has many stages. My suggestion is to remove this line or add another configuration command to control this behavior (which seems like overkill).

Nice project!

takahi-i commented 9 years ago

Thank you very much for the comment @jim-edmiston! We will look into the function.

ainoya commented 9 years ago

I want to control what is being sent out to my Slack client, especially if the build file has many stages.

You're right, I think it's good to add some options to overkill or abbreviate or limit output of stage.

Nice project!

:blush:

takahi-i commented 9 years ago

I will add a option suppress to suppress specified outputs.

messenger:
  type: slack
  channel: $SLACK_CHANNEL
  username: $SLACK_USER_NAME
  url: $SLACK_URL
  suppress: 
      - result
      - stdout
      - stderr

Users add output types which they want suppress the results. The above setting suppress all the results from the stages (result, stdout, stderr).

takahi-i commented 9 years ago

Fixed with #125.

takahi-i commented 9 years ago

@ghost Please reopen this issue or create a new one if you are not satisfied with the feature.