walter 1.3.0 is degraded in messenger

[cynipe]

Colorize and suppress option in messenger is seems like degraded in v1.3.0.

You could reproduce with following codes:

reproduce.sh:

#!/bin/bash
set -e

download_walter() {
  local version=$1
  curl -sSL https://github.com/walter-cd/walter/releases/download/v${version}/walter_${version}_darwin_amd64.zip | tar xz \
    && mv walter_darwin_amd64 walter-${version} \
    && rm -rf walter_darwin_amd64
}
run() {
  local version=$1
  walter-${version}/walter -v
  walter-${version}/walter -c walter.yml
}

[ -d 'walter-1.2.0' ] || download_walter 1.2.0
[ -d 'walter-1.3.0' ] || download_walter 1.3.0

run 1.2.0
run 1.3.0

walter.yml

messenger:
  type: slack
  channel: "#channel"
  username: user
  url: "webhook-url"
  suppress:
    - stdout
    - stderr

pipeline:
  - name: hoge
    type: command
    command: echo "hello, world, hoge"
    report_full_output: true
  - name: foo
    type: command
    command: echo "hello, world, foo"
    report_full_output: true
  - name: bar
    type: command
    command: echo "hello, world, bar"
    report_full_output: true

Result

[mizzy]

Thanks for reporting and sorry for the inconvenience. I will check it and fix soon.

[takahi-i]

Very sorry for the inconvenience @cynipe. The files in the release page were not correct ones. I replaced them to the latest. In my environment the replaced files have the expected behavior (color and suppress) with your script. Please let us know when you have still have the problem.

[cynipe]

Download new binary fix this issue. Thanks!!

However, for my later understanding, may I ask why this happens? Both binaries print the same version when I run walter -v and it's really curious to me. I don't have much understanding in golang field, but have heard that golang has no versioning for dependency management. Is this issue because of that?

[takahi-i]

However, for my later understanding, may I ask why this happens?

To be honest, I have not understood the reason but it seems that goxc loaded the wrong source in the gopath directory. When I clean up and rebuild the gopath directory, the problem wass fixed.

[cynipe]

Sorry for the late reply.

hmm... so it's probably the gopath or goxc problem... Anyway, thanks for your explanation and the fixing :)