search

walter-cd / walter

Tiny deployment pipeline
http://walter-cd.net
Apache License 2.0
438 stars 39 forks source link

update godeps.json to include missing dependencies #140

Closed swdunlop closed 8 years ago

swdunlop commented 8 years ago

A clean build of walter following the README.md results in the following errors:

godep: Dep (github.com/stretchr/testify) restored, but was unable to load it with error:
    Package (github.com/stretchr/objx) not found
godep: Dep (github.com/google/go-github/github) restored, but was unable to load it with error:
    Package (github.com/google/go-querystring/query) not found
godep: Error checking some deps.

The version of godep built by walter was godep v44 (linux/amd64/go1.4.2). The problem can be reproduced using the following:

build@scdunlop ~/build> env  | grep '^GO'
build@scdunlop ~/build> git clone https://github.com/walter-cd/walter
Cloning into 'walter'...
remote: Counting objects: 1577, done.
remote: Total 1577 (delta 0), reused 0 (delta 0), pack-reused 1577
Receiving objects: 100% (1577/1577), 306.90 KiB | 0 bytes/s, done.
Resolving deltas: 100% (917/917), done.
Checking connectivity... done.
build@scdunlop ~/build> cd walter/
build@scdunlop ~/b/walter> ./build
godep: Dep (github.com/stretchr/testify) restored, but was unable to load it with error:
    Package (github.com/stretchr/objx) not found
godep: Dep (github.com/google/go-github/github) restored, but was unable to load it with error:
    Package (github.com/google/go-querystring/query) not found
godep: Error checking some deps.

The fix appears to be injecting the three missing dependencies via godeps and regenerating godeps.json; this pull request updates the godeps.json and walter builds successfully. (I might have done things a bit backwards, godeps is novel for me.)

swdunlop commented 8 years ago

I'll re-open with an updated merge; my local copy for the update was v1.1.0, which is considerably out of date.