search

walterpg / google-drive-sync

A KeePass Password Safe v2 plugin for synchronizing passwords to Google Drive files.
GNU General Public License v3.0
198 stars 10 forks source link

4.0.5 and older: Updatecheck fails - Signature issue? #34

Closed Rookiestyle closed 3 years ago

Rookiestyle commented 3 years ago

Since the release of 4.0.6, KeePass' update check cannot parse the version information file while the plugin update has not yet been done.

Update Check showed "Update check failed. Version infomration file could not be downloaded." while still using 4.0.5 Update check shows "Up to date" after the upgrade

There seems to be an issue when verifying the signature. I assume this is related to the name change, as this issue disappears after I upgraded from 4.0.5 to 4.0.6

walterpg commented 3 years ago

The former public sig was purposely munged, like after the prior name change.

I have no experience with such things, but I understand there are plugins that manage plugins based on the KP update check. Which is better, "new version available" or a "failure" status? Either way the only remedy is uninstalling - this is not a drag & drop upgrade due to the renaming.

Since there is no "KeePass Sync for Google Drive"v4.0.6, should the update check appear to claim there is one? Or is showing something silly like new version v19.9.9.9 a better idea? I really don't know the right answer here.

Rookiestyle commented 3 years ago

At the end this boils down to the question: Is KPSync for Google Drive a new plugin or a new version and one of the changes is a renaming?

"Update check failed" for me always indicates a technical issue like missing internet connection, version info file not available, ...

Please see https://kpsync.org for the latest rebranded release.

If this info included in the old version info file was shown to the users, it would be very helpful. Unfortunately it is not shown as it cannot be parsed s version number

My personal opinion: Showing it as "new version available" is better as users are aware that there is a change and the should update to 4.0.6, 4.07, ... and hopefully many more versions - this is not impacted by their usage/non-usage of other update-check-related plugins.

"Better" in this context of course depends on one's view, there is no 100% clear way to answer this question.