search

walterpg / google-drive-sync

A KeePass Password Safe v2 plugin for synchronizing passwords to Google Drive files.
GNU General Public License v3.0
199 stars 10 forks source link

Duplicated "Enable Legacy Oauth" section #35

Open dregad opened 3 years ago

dregad commented 3 years ago

Describe the bug In the Configuration dialog, the Enable Legacy Oauth 2.0 Credentials section is present under both the Sync Authorization and Options and Defaults tab

To Reproduce Steps to reproduce the behavior:

  1. Go to Tools > KPSync > Configure
  2. Notice Legacy Oauth section at bottom
  3. Click on Options and Defaults tab
  4. Notice duplicated section

Expected behavior Only a single occurence is required, or am I missing something ?

Screenshots Unnecessary I guess, but if you need them let me know

Please complete the following information:

Additional context N/A

dregad commented 3 years ago

As a side note, when the Enable checkbox is not checked, the Help and Google Developer Console links at the bottom remain visible as non-actionable text. Maybe they should be hidden instead, to avoid confusion.

walterpg commented 3 years ago

The Options and Defaults tab contains controls for configuring plugin options affecting usage with all existing databases, and future databases. A user who wants to use the same personal OAuth 2.0 creds for every database created in the future, would enter those credentials there. If, on the other hand, a user wanted to change the personal OAuth 2.0 creds for the currently open database, they would use the similar controls of the Sync Authorization tab.

Given that personal OAuth 2.0 creds support is a DEPRECATED feature, perhaps the issue could be rephrased in those terms, e.g., "Remove deprecated features from 'Options and Defaults' configuration controls".

Anyone else interested in this feature/bug care to comment?

dregad commented 3 years ago

perhaps the issue could be rephrased in those terms, e.g., "Remove deprecated features from 'Options and Defaults' configuration controls".

Fine with me

Anyone else interested in this feature/bug care to comment?

Guess not 😉

walterpg commented 3 years ago

Anyone else interested in this feature/bug care to comment?

Guess not 😉

There is still interest in deprecated features (#42), however I don't think removing the "default for new databases" in this case would distract from that.

I could be mistaken.