search

walterra / d3-milestones

A d3 based timeline visualization.
https://walterra.github.io/d3-milestones
Other
146 stars 27 forks source link

add event click, mousever, and mouseleave API #3

Closed superpikar closed 5 years ago

superpikar commented 5 years ago
superpikar commented 5 years ago

Hi @walterra,

You've made a great chart! It helps me visualize meetings history in my project.

How do you think about my pull request proposal? The reason behind my pull request is I need to trigger an event when user mouse over, mouse leave, or click the text in the milestones chart.

walterra commented 5 years ago

Hey @superpikar — thank you so much for the PR, happy to hear you like the visualization! I'm traveling at the moment but will have a closer look next week!

walterra commented 5 years ago

@superpikar I just updated some dependencies in master which now already includes package-lock.json and yarn.lock, can you please rebase your PR so that the conflicts are resolved.

superpikar commented 5 years ago

@walterra Git rebase is done. Btw, this is my first time doing git rebase, let me know if I am doing something wrong.

walterra commented 5 years ago

@superpikar I'm not completely sure what went wrong with your rebase but somehow it still shows a lot of changes in the diff which are already part of master. I cherry-picked your original contribution into a new branch and created another PR here https://github.com/walterra/d3-milestones/pull/4

I will close this PR and merge the other one. Because of the cherry-pick your code will still be attributed to you in the git history even if the new PR was created by me. Thank you very much for the contribution, it will be part of the next release/tag.

superpikar commented 5 years ago

@walterra Um, maybe I should learn more about git. Thank you for merging my contribution :)