search

walterra / d3-milestones

A d3 based timeline visualization.
https://walterra.github.io/d3-milestones
Other
146 stars 27 forks source link

Changing selection.empty() to be selection.html(null) #7

Closed avborhanian closed 5 years ago

avborhanian commented 5 years ago

selection.empty checks if it contains no elements. selection.html with a null value will clear the contents of node.

Fixes issue #6.

qualiture commented 5 years ago

I would like to see this fix merged too. Right now, resizing the container re-adds the data multiple times

walterra commented 5 years ago

Hey, thank you so much for this PR! Something is truly wrong with my github notifications I didn't get a ping to look at it! Will merge and release soon!

walterra commented 5 years ago

Part of new release alpha13 https://github.com/walterra/d3-milestones/releases/tag/v1.0.0-alpha13