Closed you3h closed 5 years ago
Sounds good, would be great if you'd do a PR!
As much as I would like to create a PR for it, git is denying my account
I'm having this error
I suspect you did not create a fork to your own namespace where you could push? If you have trouble creating the PR, please just post your updated file in a gist or somewhere else and link to it here.
Hi @walterra I've created a pull request, I hope you could check that :)
Hi walterra, I would just like to follow up on this issue, I submitted a PR :)
@jelohipolitocruz Thanks for your contribution, I just merged the PR (#10) and released a new version https://github.com/walterra/d3-milestones/releases/tag/v1.0.0-alpha14
So I'm having this issue that the last element is not having this class, so I tried to update the main.js and added a Math.round in mostRightPosition variable and it worked. do you mind me submitting PR for it?