fix: Capitalize rpc and messages to conform buf lint and fix `service.go` visibility

walterwanderley / sqlc-grpc

Create a gRPC server from code generated by sqlc

MIT License

127 stars 13 forks source link

fix: Capitalize rpc and messages to conform buf lint and fix `service.go` visibility #9

Closed iamwavecut closed 9 months ago

iamwavecut commented 9 months ago

To reproduce the bug, you may create the queries.sql that contains lowercase names, that breaks generated sources by inheriting that lowercase names as struct names and methods names, which lead to generating non-exported methods and entities in the API.

iamwavecut commented 9 months ago

I believe I should move this fix deeper, to eliminate the single point of failure.

iamwavecut commented 9 months ago

I'm stopping right now as the easiest workaround is to capitalize the first letter of query names, and a global fix would introduce a lot of work I currently have no time nor package knowledge to conduct. FYI @walterwanderley

walterwanderley commented 9 months ago

Fixed on the version v0.18.4